Skip to content

fix: update configuration service when overriding configuration#2784

Draft
metacosm wants to merge 1 commit intomainfrom
update-configuration-registration
Draft

fix: update configuration service when overriding configuration#2784
metacosm wants to merge 1 commit intomainfrom
update-configuration-registration

Conversation

@metacosm
Copy link
Collaborator

@metacosm metacosm commented May 7, 2025

Signed-off-by: Chris Laprun claprun@redhat.com

@metacosm
fix: update configuration service when overriding configuration
c922227 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@metacosm metacosm self-assigned this May 7, 2025
@metacosm metacosm requested review from csviri and xstefank May 7, 2025 06:50
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
@metacosm metacosm mentioned this pull request May 7, 2025
Closed
@metacosm
Copy link
Collaborator Author

metacosm commented May 7, 2025

Currently, the configuration information related to a reconciler can be inconsistent between what's returned by the ConfigurationService and what can be returned by RuntimeInfo from RegisteredController (which should be the correct version, in case they differ). The problem is RuntimeInfo is not very well known and not as widely used as ConfigurationService, which means that users can observe outdated configuration.

@goldmann goldmann mentioned this pull request May 12, 2025
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2025
@openshift-merge-robot
Copy link

openshift-merge-robot commented Sep 26, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csviri
Copy link
Collaborator

csviri commented Oct 2, 2025

How can be that outdated, if it is immutable?

@csviri
Copy link
Collaborator

csviri commented Oct 2, 2025

Note that only change that now allow in runtime is changing watched namespaces through RegisteredController. After start no configuration other than this should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xstefank xstefank xstefank approved these changes

@csviri csviri Awaiting requested review from csviri

Assignees

@metacosm metacosm

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@metacosm @openshift-merge-robot @csviri @xstefank